[webkit-reviews] review requested: [Bug 42036] svn-unapply warns of uninitialized variable when unapplying a patch that describes an svn move operation : [Attachment 61168] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has asked  for review:
Bug 42036: svn-unapply warns of uninitialized variable when unapplying a patch
that describes an svn move operation
https://bugs.webkit.org/show_bug.cgi?id=42036

Attachment 61168: Patch
https://bugs.webkit.org/attachment.cgi?id=61168&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
The issue is that for an SVN copy/move	we do not pass the hash key
svnConvertedText in the hash we pass to the patch() function because it is not
necessary when performing such an operation (i.e. there are no additional
changes to unapply to the copied/moved file; we are just going to remove the
file. If there were additional changes made to the copied/moved file, as
described by the patch we are unapplying, these would appear as separate diffs
that would have already been unapplied).

I'm unclear how best to test since it it very specific to svn-unapply and
patch() makes file system calls which we would need to either mock out or
actually perform similar to the way we do the WebKit python SCM tests. I am
open to suggestions.