[webkit-reviews] review granted: [Bug 41941] Clean up as many unnecessary includes in header files as possible : [Attachment 61140] patch #3: WebCore/dom + fix to WebCore/css/StyleMedia.h

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 9 22:35:59 PDT 2010


Darin Adler <darin at apple.com> has granted Dumitru Daniliuc
<dumi at chromium.org>'s request for review:
Bug 41941: Clean up as many unnecessary includes in header files as possible
https://bugs.webkit.org/show_bug.cgi?id=41941

Attachment 61140: patch #3: WebCore/dom + fix to WebCore/css/StyleMedia.h
https://bugs.webkit.org/attachment.cgi?id=61140&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Looks good.

You should know that in many cases we can compile headers that declare, but do
not define, functions that use PassRefPtr.h without even including
PassRefPtr.h. Instead we can include <wtf/Forward.h>. That’s the purpose of the
Forward.h function. To be a smaller header with forward declarations of
templates where you can’t just forward declare the class in the usual way. I
don’t know if that’s an important optimization, though. Code that uses
PassRefPtr is going to need to include PassRefPtr.h eventually anyway.


More information about the webkit-reviews mailing list