[webkit-reviews] review requested: [Bug 41259] Interacting with a <select> element within a transformed and clipped container scrolls the container : [Attachment 61132] patch and testcase

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 9 18:17:10 PDT 2010


Dean Jackson <dino at apple.com> has asked  for review:
Bug 41259: Interacting with a <select> element within a transformed and clipped
container scrolls the container
https://bugs.webkit.org/show_bug.cgi?id=41259

Attachment 61132: patch and testcase
https://bugs.webkit.org/attachment.cgi?id=61132&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
Patch and testcase. The ContainerNode::getRect call (and the two methods
changed here) are quite concerning. Many of the comments indicate that its
behaviour has been lost in time. 

Anyway, this patch fixes the raised bug, hopefully makes all of this code
transform aware, and has a test case to make sure nothing has broken. The test
case exercises many of the code paths in the ContainerNode methods.


More information about the webkit-reviews mailing list