[webkit-reviews] review denied: [Bug 42014] Tidy up lexer token ids : [Attachment 61127] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Oliver Hunt <oliver at apple.com>'s
request for review:
Bug 42014: Tidy up lexer token ids
https://bugs.webkit.org/show_bug.cgi?id=42014

Attachment 61127: Patch
https://bugs.webkit.org/attachment.cgi?id=61127&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
You need to change parseEQUALmentExpression, m_EQUALmentCount, and
initialEQUALments back.

Also, why do these token enum values all need TO SHOUT ALL THE TIME. I CAN HEAR
THEM EVEN IN MIXED CASE.

Typically people do that with macros because they are so dangerous, but if
they’re just normal C objects I suggest not using all capitals.