[webkit-reviews] review granted: [Bug 42005] CanvasSurface should go away (there is no OffscreenCanvas) : [Attachment 61119] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 9 17:37:56 PDT 2010


Darin Adler <darin at apple.com> has granted James Robinson
<jamesr at chromium.org>'s request for review:
Bug 42005: CanvasSurface should go away (there is no OffscreenCanvas)
https://bugs.webkit.org/show_bug.cgi?id=42005

Attachment 61119: Patch
https://bugs.webkit.org/attachment.cgi?id=61119&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +    static const float MaxCanvasArea;
> +    static const int DefaultWidth;
> +    static const int DefaultHeight;

We normally use file-local constants instead of constant static data members.

r=me


More information about the webkit-reviews mailing list