[webkit-reviews] review granted: [Bug 42004] bufferSubData causes crash in WebGLBuffer::associateBufferSubData : [Attachment 61114] Patch

[bugzilla-daemon at webkit.org]

Nate Chapin <japhet at chromium.org> has granted Kenneth Russell
<kbr at google.com>'s request for review:
Bug 42004: bufferSubData causes crash in WebGLBuffer::associateBufferSubData
https://bugs.webkit.org/show_bug.cgi?id=42004

Attachment 61114: Patch
https://bugs.webkit.org/attachment.cgi?id=61114&action=review

------- Additional Comments from Nate Chapin <japhet at chromium.org>
>      case GraphicsContext3D::ELEMENT_ARRAY_BUFFER:
>      case GraphicsContext3D::ARRAY_BUFFER:
>	   m_byteLength = size;
> +	   if (m_target == GraphicsContext3D::ELEMENT_ARRAY_BUFFER) {
> +	       clearCachedMaxIndices();
> +	       m_elementArrayBuffer = ArrayBuffer::create(size, 1);
> +	       if (!m_elementArrayBuffer) {
> +		   m_byteLength = 0;
> +		   return false;
> +	       }
> +	   }
>	   return true;
>      default:
>	   return false;

Style nit: exit early if m_target is 0, and remove the switch.