[webkit-reviews] review requested: [Bug 41569] [Chromium] Expose basic DOM information in WebAccessibilityObject : [Attachment 61110] Got rid of WebNode::element()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 9 15:55:45 PDT 2010


Dominic Mazzoni <dmazzoni at google.com> has asked  for review:
Bug 41569: [Chromium] Expose basic DOM information in WebAccessibilityObject
https://bugs.webkit.org/show_bug.cgi?id=41569

Attachment 61110: Got rid of WebNode::element()
https://bugs.webkit.org/attachment.cgi?id=61110&action=review

------- Additional Comments from Dominic Mazzoni <dmazzoni at google.com>
OK, WebNode::element() is gone.

This may be a stupid question, but is there a cleaner way to cast a WebNode to
a WebElement? I added it because I thought this would be ugly:

WebKit::WebElement element(*reinterpret_cast<WebKit::WebElement*>(&node));

If you have a suggestion for a cleaner way to cast WebNode to WebElement,
that's great - but it doesn't matter because either way it will get reviewed
shortly in a Chromium patch. :)


More information about the webkit-reviews mailing list