[webkit-reviews] review granted: [Bug 41982] Improve vsprops copying for Windows build : [Attachment 61088] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jul 9 14:39:37 PDT 2010
Adam Roben (aroben) <aroben at apple.com> has granted Steve Falkenburg
<sfalken at apple.com>'s request for review:
Bug 41982: Improve vsprops copying for Windows build
https://bugs.webkit.org/show_bug.cgi?id=41982
Attachment 61088: Patch
https://bugs.webkit.org/attachment.cgi?id=61088&action=review
------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> + When we detect a new SDK, always copy a new set of vsprops files.
> + Previously, if someone updated their SDK after updating their
sources,
> + they could end up with out-of-date vsprops files.
"SDK" doesn't make much sense to people outside Apple.
I guess another option would be to do this deletion as part of our "get me the
latest SDK" script.
r=me
More information about the webkit-reviews
mailing list