[webkit-reviews] review denied: [Bug 41569] [Chromium] Expose basic DOM information in WebAccessibilityObject : [Attachment 61080] New classes now use WebPrivatePtr
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jul 9 14:38:21 PDT 2010
Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Dominic Mazzoni
<dmazzoni at google.com>'s request for review:
Bug 41569: [Chromium] Expose basic DOM information in WebAccessibilityObject
https://bugs.webkit.org/show_bug.cgi?id=41569
Attachment 61080: New classes now use WebPrivatePtr
https://bugs.webkit.org/attachment.cgi?id=61080&action=review
------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
WebKit/chromium/public/WebNode.h:106
+ WEBKIT_API WebElement element() const;
I don't think we need to add this element accessor. we already
have isElementNode(), which makes it easy to test if a WebNode
is a WebElement.
otherwise, this change LGTM
More information about the webkit-reviews
mailing list