[webkit-reviews] review granted: [Bug 41985] rebaseline_chromium_webkit_tests missing --use_drt option on linux : [Attachment 61093] fixed up spacing + help message.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 9 14:25:01 PDT 2010


David Levin <levin at chromium.org> has granted Albert J. Wong
<ajwong at chromium.org>'s request for review:
Bug 41985: rebaseline_chromium_webkit_tests missing --use_drt option on linux
https://bugs.webkit.org/show_bug.cgi?id=41985

Attachment 61093: fixed up spacing + help message.
https://bugs.webkit.org/attachment.cgi?id=61093&action=review

------- Additional Comments from David Levin <levin at chromium.org>
A few things that would be nice to fix before landing are below.

> diff --git a/WebKitTools/ChangeLog b/WebKitTools/ChangeLog
> +2010-07-09  Albert J. Wong  <ajwong at chromium.org>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   rebaseline_chromium_webkit_tests missing --use_drt option on linux
> +	   https://bugs.webkit.org/show_bug.cgi?id=41985
> +
> +	   This add in the --use_drt option for into

s/add/adds/
s/for into/for/


> diff --git
a/WebKitTools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py
b/WebKitTools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py

> +    option_parser.add_option('', '--use_drt',
> +				action='store_true',
> +				default=False,
> +				help=('Use ImageDiff from DumpRenderTree
instead '
> +				      'of image_diff for pixel tests'))

Add a . to the end of the sentence.


More information about the webkit-reviews mailing list