[webkit-reviews] review requested: [Bug 21680] queryCommandValue("BackColor") returns rgb(0, 0, 0) for elements with transparent background : [Attachment 61087] merged valueStyle in EditorCommand.cpp and Frame::selectionStartStylePropertyValue and added a special case to treat background color

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has asked  for review:
Bug 21680: queryCommandValue("BackColor") returns rgb(0,0,0) for elements with
transparent background
https://bugs.webkit.org/show_bug.cgi?id=21680

Attachment 61087: merged valueStyle in EditorCommand.cpp and
Frame::selectionStartStylePropertyValue and added a special case to treat
background color
https://bugs.webkit.org/attachment.cgi?id=61087&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
This patch merges valueStyle in EditorCommand.cpp and
Frame::selectionStartStylePropertyValue because
selectionStartStylePropertyValue was only used in valueStyle.  I added a
special case for background color where I check whether the style has
transparent background or the current selection is a range.  In either cases,
new valueStyle will traverse the tree upwards until it gets a computed style
with non-transparent background.  I could improve the change log so give me
some feedback please.