[webkit-reviews] review granted: [Bug 41949] Implement SVG attribute case mapping for HTMLTreeBuilder : [Attachment 61073] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jul 9 12:42:51 PDT 2010
Adam Barth <abarth at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 41949: Implement SVG attribute case mapping for HTMLTreeBuilder
https://bugs.webkit.org/show_bug.cgi?id=41949
Attachment 61073: Patch
https://bugs.webkit.org/attachment.cgi?id=61073&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
WebCore/html/HTMLTreeBuilder.cpp:742
+ for (unsigned x = 0; x < attributes->length(); ++x) {
I'd prefer "i" here, but whatever.
WebCore/html/HTMLTreeBuilder.cpp:743
+ Attribute* attribute = attributes->attributeItem(x);
I'm not sure what the internal structure of the attributes data structure is.
Is it efficient to index each time, or is there an iterator API we should be
using.
More information about the webkit-reviews
mailing list