[webkit-reviews] review denied: [Bug 41384] Allow Chromium access to Select control choices : [Attachment 61066] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied George Yakovlev
<georgey at chromium.org>'s request for review:
Bug 41384: Allow Chromium access to Select control choices
https://bugs.webkit.org/show_bug.cgi?id=41384

Attachment 61066: Patch
https://bugs.webkit.org/attachment.cgi?id=61066&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
WebKit/chromium/public/WebOptionElement.h:60
 +	WEBKIT_API bool disabled() const;
hmm... this 'disabled' method seems similar to the inherited
WebFormControlElement::isEnabled?  i see from reading the
implementation that it does a bit more (checks the parent's
disabled state as well).  it seems to me that it would be
better to name this one isEnabled as well.

WebKit/chromium/src/WebSelectElement.cpp:59
 +	    items[i] =
WebOptionElement(static_cast<HTMLOptionElement*>(sourceItems[i]));
I think you need to check that sourcesItems[i]->hasLocalName(optionTag)
is true before casting to HTMLOptionElement.

I'm basing this on the implementation of HTMLSelectElement::value().
You could also just return a WebVector<WebElement>, and then leave
it up to the consumer to use WebElement::hasTagName.