[webkit-reviews] review denied: [Bug 39624] --squash should go away and become the default : [Attachment 60408] Support --git-commit=HEAD..

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 39624: --squash should go away and become the default
https://bugs.webkit.org/show_bug.cgi?id=39624

Attachment 60408: Support --git-commit=HEAD..
https://bugs.webkit.org/attachment.cgi?id=60408&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Can we be more user friendly during the transition?  Maybe we should understand
--no-squash and print a message that explains the new way is
--git-commit=HEAD.. ?  Another option is to automatically re-write --no-squash
into --git-commit=HEAD..  Some minor comments below.

WebKitTools/Scripts/webkitpy/tool/steps/checkstyle_unittest.py:38
 +	pass
Should we delete this file if there aren't any tests in it?

WebKitTools/Scripts/webkitpy/tool/steps/commit.py:68
 +		username = User.prompt("%s login: " % e.server_host, repeat=5)
You should use self._tool.user here.

WebKitTools/Scripts/webkitpy/tool/steps/commit.py:71
 +		self._commit(username=username)
What if this throws an AmbiguousCommitError?  I think you want to use some sort
of loop with these things as state variables.  You can put a retry limit in the
loop if you're worried about going infinite.

WebKitTools/ChangeLog:9
 +	    need to be met by a wrapper script around webkit-patch.
This isn't really true anymore, right?	I can use --git-commit=HEAD..