[webkit-reviews] review granted: [Bug 41913] XPath substring function has inconsistent handling of negative values for the position argument : [Attachment 61054] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Steve Block
<steveblock at google.com>'s request for review:
Bug 41913: XPath substring function has inconsistent handling of negative
values for the position argument
https://bugs.webkit.org/show_bug.cgi?id=41913

Attachment 61054: Patch
https://bugs.webkit.org/attachment.cgi?id=61054&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
> +	   we reset the position to 1. This matches the current behaviour when
a length
> +	   argument is supplied.

This fix is not really about consistency - there is a rigorous spec, and we now
match it. Does the new test pass in Firefox?

r=me