[webkit-reviews] review denied: [Bug 41941] Clean up as many unnecessary includes in header files as possible : [Attachment 61021] patch #1: WebCore/accessibility

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Dumitru Daniliuc <dumi at chromium.org>'s
request for review:
Bug 41941: Clean up as many unnecessary includes in header files as possible
https://bugs.webkit.org/show_bug.cgi?id=41941

Attachment 61021: patch #1: WebCore/accessibility
https://bugs.webkit.org/attachment.cgi?id=61021&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> Index: WebCore/accessibility/AccessibilityListBox.cpp
> ===================================================================
> --- WebCore/accessibility/AccessibilityListBox.cpp	(revision 62919)
> +++ WebCore/accessibility/AccessibilityListBox.cpp	(working copy)
> @@ -31,6 +31,7 @@
>  
>  #include "AXObjectCache.h"
>  #include "AccessibilityListBoxOption.h"
> +#include "AccessibilityObject.h"
>  #include "HTMLNames.h"
>  #include "HTMLSelectElement.h"
>  #include "HitTestResult.h"

There's no need to add this. AccessibilityListBox is derived from a class
that's derived from AccessibilityObject. If the script is telling you to add
this, we need to improve the script.

> +class AccessibilityObject;
> +
>  class AccessibilityListBox : public AccessibilityRenderObject {

There's no need to add the forward declaration for AccessibilityObject here.
AccessibilityRenderObject is derived from AccessibilityObject. Again, if the
script is telling you to add this, we need to improve the script.

Otherwise, the patch seems fine as long as it doesn't break the build on any
platform.