[webkit-reviews] review granted: [Bug 41862] [Arm] Missing NaN check in XPath substring function : [Attachment 61037] Patch and layout test.

[bugzilla-daemon at webkit.org]

Steve Block <steveblock at google.com> has granted Ben Murdoch <benm at google.com>'s
request for review:
Bug 41862: [Arm] Missing NaN check in XPath substring function
https://bugs.webkit.org/show_bug.cgi?id=41862

Attachment 61037: Patch and layout test.
https://bugs.webkit.org/attachment.cgi?id=61037&action=review

------- Additional Comments from Steve Block <steveblock at google.com>
LayoutTests/fast/xpath/substring-nan-position-expected.txt:5
 +  PASS document.evaluate("substring('12345', number('NaN'), -2147483645)",
document, null, XPathResult.STRING_TYPE, null).stringValue is ''
I think you should add a comment to the ChangeLog to make clear that only this
particular test is fixed by the patch. The others just cover other edge cases
that already pass. It would also be good to add a brief comment here explaining
what the magic number is.

WebCore/ChangeLog:13
 +		argument and early out if the value is indeed NaN.
'early out and return the empty string'