[webkit-reviews] review granted: [Bug 41820] commit-queue and EWS bots should report all failures : [Attachment 60815] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 41820: commit-queue and EWS bots should report all failures
https://bugs.webkit.org/show_bug.cgi?id=41820

Attachment 60815: Patch
https://bugs.webkit.org/attachment.cgi?id=60815&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
WebKitTools/Scripts/webkitpy/tool/commands/queues.py:139
 +	    log_file = cls._log_from_script_error_for_upload(script_error)
You never do anything with the log_file :)

WebKitTools/Scripts/webkitpy/tool/commands/queues.py:215
 +		failure_log = self._log_from_script_error_for_upload(e)
Inconsistent naming of the result of this function.