[webkit-reviews] review granted: [Bug 41943] Add basic "in foreign content" support to the TreeBuilder : [Attachment 61020] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 41943: Add basic "in foreign content" support to the TreeBuilder
https://bugs.webkit.org/show_bug.cgi?id=41943

Attachment 61020: Patch
https://bugs.webkit.org/attachment.cgi?id=61020&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Cool!

WebCore/html/HTMLElementStack.cpp:336
 +  bool HTMLElementStack::isOnlyHTMLElementsInScope() const
hasOnlyHTMLElementsInScope ?

WebCore/html/HTMLTreeBuilder.cpp:1395
 +	    else
This doesn't work right if MATHML is turned on and SVG is off.

WebCore/html/HTMLTreeBuilder.cpp:1402
 +	    m_tree.insertForeignElement(token,
m_tree.currentElement()->namespaceURI());
Why do we re-read this instead of using currentNamespace?

WebCore/html/HTMLTreeBuilder.cpp:2194
 +	    if (token.name() == SVGNames::scriptTag &&
m_tree.currentElement()->hasTagName(SVGNames::scriptTag)) {
Missing #ifdef SVG

WebCore/html/HTMLTreeBuilder.cpp:2236
 +	}
insert blank line