[webkit-reviews] review granted: [Bug 41941] Clean up as many unnecessary includes in header files as possible : [Attachment 61021] patch #1: WebCore/accessibility

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 9 02:21:32 PDT 2010


Eric Seidel <eric at webkit.org> has granted Dumitru Daniliuc
<dumi at chromium.org>'s request for review:
Bug 41941: Clean up as many unnecessary includes in header files as possible
https://bugs.webkit.org/show_bug.cgi?id=41941

Attachment 61021: patch #1: WebCore/accessibility
https://bugs.webkit.org/attachment.cgi?id=61021&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
AX is actually a horrible offender of header includes.	lots and lots of
needlessly inline functions which cause massive header cascades. :(

I would think this type of patch would be a really good candidate for the cq?  
I'm surprised you cq-'d it, as the cq would be happy to build it for you before
landing.


More information about the webkit-reviews mailing list