[webkit-reviews] review granted: [Bug 41461] Web Inspector: all breakpoints are activated on page reload : [Attachment 60900] Updated test.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jul 9 01:52:08 PDT 2010
Yury Semikhatsky <yurys at chromium.org> has granted Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 41461: Web Inspector: all breakpoints are activated on page reload
https://bugs.webkit.org/show_bug.cgi?id=41461
Attachment 60900: Updated test.
https://bugs.webkit.org/attachment.cgi?id=60900&action=review
------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
LayoutTests/inspector/debugger-breakpoints-not-activated-on-reload.html:112
+ frontend_addSniffer(view, "_sourceFrameSetupFinished",
function(event)
Please extract common code that waits for frame loading before executing
callback from here and frontend_checkExecutionLineWhenSourceFrameIsLoaded in
debugger-pause-in-eval-script.html test.
LayoutTests/inspector/debugger-breakpoints-not-activated-on-reload.html:56
+ function frontend_scriptsAreParsed(scripts)
you may want to move these methods to debugger-test.js
More information about the webkit-reviews
mailing list