[webkit-reviews] review granted: [Bug 41935] Add RuntimeEnabledFeatures::timeRangesEnabled() required by r62880 : [Attachment 61006] Add in timeRangesEnable()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 9 00:36:43 PDT 2010


Nikolas Zimmermann <zimmermann at kde.org> has granted Albert J. Wong
<ajwong at chromium.org>'s request for review:
Bug 41935: Add RuntimeEnabledFeatures::timeRangesEnabled() required by r62880
https://bugs.webkit.org/show_bug.cgi?id=41935

Attachment 61006: Add in timeRangesEnable()
https://bugs.webkit.org/attachment.cgi?id=61006&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
LGTM, r=me.We were both not 100% sure whether timeRangesEnabled() should be 1:1
coupled with the MediaPlayer availability. But as TimeRanges is
conditional=video, and it's also exposed only if VIDEO is enabled, it seems
fine.


More information about the webkit-reviews mailing list