[webkit-reviews] review denied: [Bug 39702] JavaScriptCore threading relies on QApplication existing : [Attachment 58663] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 8 23:46:28 PDT 2010


Simon Hausmann <hausmann at webkit.org> has denied Anders Bakken
<agbakken at gmail.com>'s request for review:
Bug 39702: JavaScriptCore threading relies on QApplication existing
https://bugs.webkit.org/show_bug.cgi?id=39702

Attachment 58663: Patch
https://bugs.webkit.org/attachment.cgi?id=58663&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
The patch/bug doesn't explain what the actual issue is that this fixes, beyond
"it's better to make sure..."

The ChangeLog is also slightly malformed, the "Reviewed by" should be at the
top.

Anders, I'm okay with the patch in principle, but it would really help to
understand your motivation behind the change. Imagine a year down the line
trying to figure out why this was changed ...

r- because of the missing explanation and malformed ChangeLog. The patch itself
is okay, once we know what it really fixes :)


More information about the webkit-reviews mailing list