[webkit-reviews] review granted: [Bug 41894] Add a script that checks for unnecessary #includes in header files : [Attachment 60974] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 8 23:40:38 PDT 2010


Darin Adler <darin at apple.com> has granted Dumitru Daniliuc
<dumi at chromium.org>'s request for review:
Bug 41894: Add a script that checks for unnecessary #includes in header files
https://bugs.webkit.org/show_bug.cgi?id=41894

Attachment 60974: patch
https://bugs.webkit.org/attachment.cgi?id=60974&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Great idea. I think we can land it as is, as long as it's not giving us any bad
advice. No real need to carefully review it.

Does this replace the existing find-extra-includes script already in the
WebKitTools/Scripts directory, or does it have a different purpose?

r=me on landing this, but please remove find-extra-includes if this replaces
it, or don’t land this if find-extra-includes already does a better job.


More information about the webkit-reviews mailing list