[webkit-reviews] review denied: [Bug 41920] Avoid slow-path for put() in Array.splice() : [Attachment 60986] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 8 23:14:00 PDT 2010


Oliver Hunt <oliver at apple.com> has denied Andreas Kling
<andreas.kling at nokia.com>'s request for review:
Bug 41920: Avoid slow-path for put() in Array.splice()
https://bugs.webkit.org/show_bug.cgi?id=41920

Attachment 60986: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=60986&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
I think this can be made much better.

We should add a function to create a new array that will actually allocate
sufficient space for the result as we know we will be producing a compact array
of this size, then resObj->put(...) should be replaced with setIndex(k, v).

--Oliver


More information about the webkit-reviews mailing list