[webkit-reviews] review granted: [Bug 41828] [chromium] Allow resizing an offscreen GLES2Context's backing store and getting its texture ID for compositing : [Attachment 60959] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jul 8 16:31:14 PDT 2010
Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted James Robinson
<jamesr at chromium.org>'s request for review:
Bug 41828: [chromium] Allow resizing an offscreen GLES2Context's backing store
and getting its texture ID for compositing
https://bugs.webkit.org/show_bug.cgi?id=41828
Attachment 60959: Patch
https://bugs.webkit.org/attachment.cgi?id=60959&action=review
------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
WebKit/chromium/public/WebGLES2Context.h:54
> + // The follow two functions are for managing a context that renders
offscreen.
nit: put a new line after this comment so that it doesn't look like
this comment is only talking about the first function?
how critical is the unsigned vs uint32_t distinction? in the webkit api,
we don't really have a uint32_t. (well, we do have one inherited from
npruntime.h, but it would be odd to use that in this context.)
anyways, r=me modulo the nit above.
More information about the webkit-reviews
mailing list