[webkit-reviews] review granted: [Bug 41895] [MathML] Implement mathcolor and mathbackground attributes : [Attachment 60957] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted François Sausset
<sausset at gmail.com>'s request for review:
Bug 41895: [MathML] Implement mathcolor and mathbackground attributes
https://bugs.webkit.org/show_bug.cgi?id=41895

Attachment 60957: Patch
https://bugs.webkit.org/attachment.cgi?id=60957&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
WebCore/mathml/MathMLElement.cpp:4
 +   * Copyright (C) 2010 François Sausset (sausset at gmail.com). All rights
reserved.
There seems to be some unicode issues here.

 62	if (attr->name() == MathMLNames::mathcolorAttr) {
 63	    addCSSProperty(attr, CSSPropertyColor, attr->value());
 64	} else if (attr->name() == MathMLNames::mathbackgroundAttr) {
 65	    addCSSProperty(attr, CSSPropertyBackgroundColor, attr->value());
 66	    
 67	} else
 68	    StyledElement::parseMappedAttribute(attr);

These one liners should not have braces. There is also a strange newline before
the last else.

Apart from this the patch looks fine. Please fix these things before
committing.