[webkit-reviews] review denied: [Bug 41864] [V8] Navigation policy doesn't play nicely with pepper plugins : [Attachment 60913] Updated patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 8 12:14:40 PDT 2010


Adam Barth <abarth at webkit.org> has denied John Abd-El-Malek
<jam at chromium.org>'s request for review:
Bug 41864: [V8] Navigation policy doesn't play nicely with pepper plugins
https://bugs.webkit.org/show_bug.cgi?id=41864

Attachment 60913: Updated patch
https://bugs.webkit.org/attachment.cgi?id=60913&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
This patch does not have a ChangeLog.

V8Utilities:103
 +  Frame* callingFrameForNavigation() {
This isn't the right name for this function.  The calling frame isn't changing
because we're interested in navigation.  Maybe the name
"activeFrameForNavigation" is better?  It's really the same thing we do for the
canAccess check, so it might be worth sharing there too.  Maybe principalFrame
(to steal some terminology from Mozilla)?


More information about the webkit-reviews mailing list