[webkit-reviews] review granted: [Bug 41885] Add a Plugin abstract base class and a DummyPlugin that implements it : [Attachment 60920] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 8 11:55:34 PDT 2010


Sam Weinig <sam at webkit.org> has granted Anders Carlsson <andersca at apple.com>'s
request for review:
Bug 41885: Add a Plugin abstract base class and a DummyPlugin that implements
it
https://bugs.webkit.org/show_bug.cgi?id=41885

Attachment 60920: Patch
https://bugs.webkit.org/attachment.cgi?id=60920&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
> +    virtual void initialize(const WebCore::String& mimeType, const
WebCore::KURL&, bool loadManually);
> +    virtual void destroy();
> +    virtual void paint(WebCore::GraphicsContext*, const WebCore::IntRect&
dirtyRect);
> +    virtual void geometryDidChange(const WebCore::IntRect& frameRect);
> +    
> +};
Extra newline'

> +};

Extra semicolon.

r=me.


More information about the webkit-reviews mailing list