[webkit-reviews] review granted: [Bug 32605] Regression: Selection anchor + focus swap when arrow keys after setBaseAndExtent : [Attachment 60917] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 32605: Regression: Selection anchor + focus swap when arrow keys after
setBaseAndExtent
https://bugs.webkit.org/show_bug.cgi?id=32605

Attachment 60917: Patch
https://bugs.webkit.org/attachment.cgi?id=60917&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
I’d rather see the enum at the global level rather than as a member. I don’t
think there’s any real danger of conflict with other similar enums.

I think we could find a better name for the enum by talking about what it is
and selecting words from that discussion. For example we could consider using
verbs like “MakeNonDirectionalSelection” and “MakeDirectionalSelection”. The
word “policy” in the name of the enum allows the enum values to be verbs
instead of adjectives or nounds.

Fine as-is, though. r=me