[webkit-reviews] review granted: [Bug 41870] WebKit2 on Windows needs a version resource : [Attachment 60909] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Steve Falkenburg
<sfalken at apple.com>'s request for review:
Bug 41870: WebKit2 on Windows needs a version resource
https://bugs.webkit.org/show_bug.cgi?id=41870

Attachment 60909: Patch
https://bugs.webkit.org/attachment.cgi?id=60909&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> Index: WebKit2/ChangeLog
> ===================================================================
> --- WebKit2/ChangeLog (revision 62802)
> +++ WebKit2/ChangeLog (working copy)
> @@ -1,3 +1,16 @@
> +2010-07-08  Steve Falkenburg  <sfalken at apple.com>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   WebKit2 on Windows needs a version resource
> +	   https://bugs.webkit.org/show_bug.cgi?id=41870
> +	   <rdar://problem/8170501>
> +
> +	   * win/WebKit2.rc: Added.
> +	   * win/WebKit2.vcproj:
> +	   * win/WebKit2WebProcess.rc: Added.
> +	   * win/WebKit2WebProcess.vcproj:

It would be great to explain the .vcproj changes, since the diffs are so
unreadable.

It might also be good to mention that these .rc files are veeeeeeery similar to
our other .rc files.

r=me