[webkit-reviews] review granted: [Bug 41529] Add the ability for user scripts and user styles to affect just the top frame : [Attachment 60786] Patch

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has granted Aaron Boodman
<aa at chromium.org>'s request for review:
Bug 41529: Add the ability for user scripts and user styles to affect just the
top frame
https://bugs.webkit.org/show_bug.cgi?id=41529

Attachment 60786: Patch
https://bugs.webkit.org/attachment.cgi?id=60786&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
WebCore/dom/Document.cpp:2156
 +		if (sheet->injectedFrames() == InjectInTopFrameOnly &&
ownerElement())
You should add a test using <frameset>. I'm curious if ownerElement() does the
right thing there. Arguably all the frames in a frameset are top level.

WebCore/page/UserStyleSheet.h:42
 +		       UserScriptInjectedFrames injectedFrames)
It is odd to use UserScriptInjectedFrames with stylesheets. Maybe
UserContentInjectedFrames? Is there a shared header it could move to as well?

WebKit/mac/WebView/WebView.mm:2382
 +		      
injectedFrames:(WebUserScriptInjectedFrames)injectedFrames
It is odd to use WebUserScriptInjectedFrames for the stylesheet case too. Maybe
WebUserContentInjectedFrames?

WebKit/mac/WebView/WebViewPrivate.h:512
 +  // FIXME: The following two methods are deprecated in favor of the
overloads below that take the WebUserScriptInjectedFrames argument.
https://bugs.webkit.org/show_bug.cgi?id=41800.
I don't think the bug is needed.