[webkit-reviews] review denied: [Bug 31253] Unbounded memory growth when adding and removing images : [Attachment 60885] Simple patch, possible solution to improve memory consumption

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 8 10:20:17 PDT 2010


Alexey Proskuryakov <ap at webkit.org> has denied Mihnea Ovidenie
<mihnea at adobe.com>'s request for review:
Bug 31253: Unbounded memory growth when adding and removing images
https://bugs.webkit.org/show_bug.cgi?id=31253

Attachment 60885: Simple patch, possible solution to improve memory consumption
https://bugs.webkit.org/attachment.cgi?id=60885&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
I didn't look at the patch, but I assume that it implements what the above
comment describes.

The reason for m_documentResources existence is so that we could provide a list
of resources to clients via -[WebDataSource subresources], store them in Web
archives, and show them in Web Inspector. Thus, removing items just because the
resource data is no longer cached is inappropriate.


More information about the webkit-reviews mailing list