[webkit-reviews] review requested: [Bug 34953] Implement DEFINE_STUB_FUNCTION for WinCE : [Attachment 60895] alternative Patch (only JITStubs.cpp, no qmake changes)

[bugzilla-daemon at webkit.org]

Patrick R. Gansterer <paroga at paroga.com> has asked  for review:
Bug 34953: Implement DEFINE_STUB_FUNCTION for WinCE
https://bugs.webkit.org/show_bug.cgi?id=34953

Attachment 60895: alternative Patch (only JITStubs.cpp, no qmake changes)
https://bugs.webkit.org/attachment.cgi?id=60895&action=review

------- Additional Comments from Patrick R. Gansterer <paroga at paroga.com>
(In reply to comment #15)
> The patch looks good to me.
> I have only one question. Why the JITSTUBS_OFFSET is hard-coded in the pro
file? Could not we use a better approach? like parsing it from JITStups.cpp or
Platform.h with the same script?
Maybe we can commit only the changes in JITStubs.cpp in the meantime?

As i know Nokia ships the sourcecode with already generated files. This means
that DerivedSources.pro should generate GeneratedJITStubs_RVCT.h, 
GeneratedJITStubs_MSVC32.asm and GeneratedJITStubs_MSVC64.asm at the same time.