[webkit-reviews] review canceled: [Bug 34953] Implement DEFINE_STUB_FUNCTION for WinCE : [Attachment 50583] The patch (corrected line endings)

[bugzilla-daemon at webkit.org]

Patrick R. Gansterer <paroga at paroga.com> has canceled Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 34953: Implement DEFINE_STUB_FUNCTION for WinCE
https://bugs.webkit.org/show_bug.cgi?id=34953

Attachment 50583: The patch (corrected line endings)
https://bugs.webkit.org/attachment.cgi?id=50583&action=review

------- Additional Comments from Patrick R. Gansterer <paroga at paroga.com>
(In reply to comment #15)
> Why the JITSTUBS_OFFSET is hard-coded in the pro file? Could not we use a
better approach? like parsing it from JITStups.cpp or Platform.h with the same
script?
It depends on USE(JSVALUE32_64) and and to get the correct one we need to pass
it to a preprecessor with all the defines.
I don't like it there too. Maybe you have a good idea to get rid of it?