[webkit-reviews] review denied: [Bug 41507] WebSocket: Crash in WorkerThreadableWebSocketChannel::waitForMethodCompletion : [Attachment 60341] Fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 7 17:16:33 PDT 2010


Alexey Proskuryakov <ap at webkit.org> has denied Yuta Kitamura
<yutak at chromium.org>'s request for review:
Bug 41507: WebSocket: Crash in
WorkerThreadableWebSocketChannel::waitForMethodCompletion
https://bugs.webkit.org/show_bug.cgi?id=41507

Attachment 60341: Fix
https://bugs.webkit.org/attachment.cgi?id=60341&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
The title of the bug isn't great - there are multiple crash locations being
fixed, not just waitForMethodCompletion(). And this isn't about creating a
WebSocket object from onclose(), as the original description said.

I think that this patch is fine, and just needs better comments.


More information about the webkit-reviews mailing list