[webkit-reviews] review granted: [Bug 41649] [chromium] Add a few more methods to WebPlugin so that Pepper v2 plugins can support copy/zoom/find : [Attachment 60797] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jul 7 16:24:27 PDT 2010
Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted John
Abd-El-Malek <jam at chromium.org>'s request for review:
Bug 41649: [chromium] Add a few more methods to WebPlugin so that Pepper v2
plugins can support copy/zoom/find
https://bugs.webkit.org/show_bug.cgi?id=41649
Attachment 60797: Patch
https://bugs.webkit.org/attachment.cgi?id=60797&action=review
------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
WebKit/chromium/src/WebFrameImpl.h:203
+ static WebPluginContainerImpl* pluginContainerFromFrame(WebCore::Frame*
frame);
nit: leave off the parameter name
WebKit/chromium/public/WebPlugin.h:108
+ // doesn't block the thread in case of a large document. The results,
along with the
nit: "is sent" -> "should be sent"?
otherwise, r=me
More information about the webkit-reviews
mailing list