[webkit-reviews] review requested: [Bug 41477] Direct calls to cast operator in WebFrameImpl.cpp : [Attachment 60792] Proposed patch. Fixes const-ness issues.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jul 7 15:46:47 PDT 2010
David Holloway <dhollowa at chromium.org> has asked for review:
Bug 41477: Direct calls to cast operator in WebFrameImpl.cpp
https://bugs.webkit.org/show_bug.cgi?id=41477
Attachment 60792: Proposed patch. Fixes const-ness issues.
https://bugs.webkit.org/attachment.cgi?id=60792&action=review
------- Additional Comments from David Holloway <dhollowa at chromium.org>
Grrrr. False positive my end. New patch addresses const-ness issues and
pushes the const-ness of the |inputElement| parameter down a level to
WebFrameImpl::getPasswordListener(). We need a const_cast at this level due to
the use of non-const RefPtr<HTMLInputElement> used as the key to the
|m_passwordListeners| map.
More information about the webkit-reviews
mailing list