[webkit-reviews] review denied: [Bug 32530] QtWebkit creates an unnecessary deep copy of images when canvas drawing is done : [Attachment 59514] Resubmitted patch without HTML tags

[bugzilla-daemon at webkit.org]

Andreas Kling <andreas.kling at nokia.com> has denied Samuel Rødal
<samuel.rodal at nokia.com>'s request for review:
Bug 32530: QtWebkit creates an unnecessary deep copy of images when canvas
drawing is done
https://bugs.webkit.org/show_bug.cgi?id=32530

Attachment 59514: Resubmitted patch without HTML tags
https://bugs.webkit.org/attachment.cgi?id=59514&action=review

------- Additional Comments from Andreas Kling <andreas.kling at nokia.com>
(In reply to comment #17)
> However I think this patch breaks the other use of StillImage in ImageQt.cpp,
where StillImage::create() is called with a temporary QPixmap. With your change
StillImage holds only a reference to the pixmap, which in that case will be a
dangling reference.

You are right.

> What about adding API to QPixmap to support this use-case?

AFAICT this is the only way out. The latest patch here will break behavior, for
example patterns created from a canvas element. They must retain an image of
the canvas contents at the time of pattern creation (this is tested by
LayoutTests/fast/canvas/canvas-pattern-modify.html)

r- for breaking behavior. Would love this improvement though.