[webkit-reviews] review granted: [Bug 41804] Disable MSVC warning 4288 : [Attachment 60785] patch

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Dumitru Daniliuc
<dumi at chromium.org>'s request for review:
Bug 41804: Disable MSVC warning 4288
https://bugs.webkit.org/show_bug.cgi?id=41804

Attachment 60785: patch
https://bugs.webkit.org/attachment.cgi?id=60785&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> +	   MSVC has a non-standard extension (/Ze /Zc:forScope-) that allows
> +	   variables declared in for-loops to remain visible in the same
> +	   scope even after the for-loop
> +	   (http://msdn.microsoft.com/en-us/library/bk5hc10s.aspx). When this
> +	   extension is enabled, re-declaring the same variable in that scope
> +	   results in a C4288 warning.
> +
> +	   At the same time, there seems to be a bug in VS2005 that
> +	   erroneously enables /Zc:forScope- even when that option is not
> +	   specified
> +	  
(http://connect.microsoft.com/VisualStudio/feedback/details/338010/bogus-compil
er-warning-c4288).

This makes it sound like the actual behavior gets enabled, not just the
warning. Explaining in the previous paragraph that /Ze turns on the behavior
and /Zc:forScope- turns on the warning could clear this up, as could changing
the description in this paragraph.

Other than that, r=me