[webkit-reviews] review granted: [Bug 41776] Need to have a way to specify different results for Windows XP and 7 : [Attachment 60780] [PATCH] Fix (one last pass)

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Brian Weinstein
<bweinstein at apple.com>'s request for review:
Bug 41776: Need to have a way to specify different results for Windows XP and 7
https://bugs.webkit.org/show_bug.cgi?id=41776

Attachment 60780: [PATCH] Fix (one last pass)
https://bugs.webkit.org/attachment.cgi?id=60780&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> -    if ($platform =~ /^mac-/) {
> +    
> +    my $isSpecificMac = $platform =~ /^mac-/;
> +    my $isWin = $platform =~ /^win/;

Doing:

my $isMac = $platform =~ /^mac/;

would have the same behavior, I believe (only "mac" will get added to
@platforms). It might be slightly easier to understand, too, since it would
make Mac and Win the same.

r=me