[webkit-reviews] review denied: [Bug 41655] Implement SVGSVGElement.getElementById : [Attachment 60748] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Rob Buis <rwlbuis at gmail.com>'s request
for review:
Bug 41655: Implement SVGSVGElement.getElementById
https://bugs.webkit.org/show_bug.cgi?id=41655

Attachment 60748: Patch
https://bugs.webkit.org/attachment.cgi?id=60748&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
What about duplicate ids?

<div id="foo">
<svg>
<rect id="foo">
</svg>
<div id="foo>

I think would cause your code to wrongly fail.	I don't remember which id wins
for "getElementById", but you want to check all of them to see if any are under
<svg> (if thee is a gitElementByIds) or you need to fall back to the walking in
teh case where you find an id but it isn't an ancestor.