[webkit-reviews] review granted: [Bug 41777] Remove needless #include <fcntl.h> from TCSystemAlloc.cpp : [Attachment 60755] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 7 12:28:40 PDT 2010


Darin Adler <darin at apple.com> has granted Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 41777: Remove needless #include <fcntl.h> from TCSystemAlloc.cpp
https://bugs.webkit.org/show_bug.cgi?id=41777

Attachment 60755: Patch
https://bugs.webkit.org/attachment.cgi?id=60755&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
It seems that that fcntl.h was needed for O_RDWR, which is used in TryDevMem,
but that's no longer compiled in our copy of this file. So it would be slightly
better to put <fcntl.h> inside #ifndef WTF_CHANGES, or maybe we should get rid
of all the #ifndef WTF_CHANGES entirely.


More information about the webkit-reviews mailing list