[webkit-reviews] review granted: [Bug 41685] DeviceOrientationEventConstructor should be exposed at window.DeviceOrientationEvent : [Attachment 60616] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jul 7 03:16:28 PDT 2010
Adam Barth <abarth at webkit.org> has granted Steve Block
<steveblock at google.com>'s request for review:
Bug 41685: DeviceOrientationEventConstructor should be exposed at
window.DeviceOrientationEvent
https://bugs.webkit.org/show_bug.cgi?id=41685
Attachment 60616: Patch
https://bugs.webkit.org/attachment.cgi?id=60616&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
The code looks right. A couple questions about the tests.
LayoutTests/fast/dom/Window/window-properties-device-orientation.html:34
+ if (typeof value == "object" && value == null) //;
Why "//;" here?
LayoutTests/fast/dom/Window/window-properties.html:86
+ "window.DeviceOrientationEvent" : 1,
Why skip this?
More information about the webkit-reviews
mailing list