[webkit-reviews] review granted: [Bug 41727] More OwnPtr work, including making clear set the pointer to 0 before deletion : [Attachment 60669] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 7 02:57:57 PDT 2010


Adam Barth <abarth at webkit.org> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 41727: More OwnPtr work, including making clear set the pointer to 0 before
deletion
https://bugs.webkit.org/show_bug.cgi?id=41727

Attachment 60669: Patch
https://bugs.webkit.org/attachment.cgi?id=60669&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Glad to see this work continue.  Please consider landing this patch in two
pieces as described below.

JavaScriptCore/wtf/OwnArrayPtr.h:72
 +	template<typename T> inline void OwnArrayPtr<T>::clear()
This change to clear() seems independent of deploying adoptPtr.  Why are we
doing them in the same patch?  It's a bit hard to foresee the consequences of
this change.  It seems like we'd be better off doing that in a separate patch.

WebCore/css/CSSSelector.h:311
 +		m_data.m_rareData = new
RareData(adoptPtr(m_data.m_tagHistory));
This adoptPtr is unfortunately far from the new...  Why doesn't the "new
RareData" have an adoptPtr?


More information about the webkit-reviews mailing list