[webkit-reviews] review canceled: [Bug 40768] Web Inspector: WebSocket in Resources tab : [Attachment 60620] Patch v4 (Fix documentURL regression)

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has canceled Yuta Kitamura
<yutak at chromium.org>'s request for review:
Bug 40768: Web Inspector: WebSocket in Resources tab
https://bugs.webkit.org/show_bug.cgi?id=40768

Attachment 60620: Patch v4 (Fix documentURL regression)
https://bugs.webkit.org/attachment.cgi?id=60620&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
WebCore/inspector/InspectorResource.cpp:415
 +	if (!m_documentURL.isNull())
This logic looks unclear. I don't think you should initialize m_documentURL in
constructor given that majority of cases it will initialize with empty URL. I'd
just assign to it when you know information is available: in
InspectorResource::updateRequest for generic resources	and in
InspectorResource::createWebSocket for web sockets. r- for that.

Otherwise, looks good.