[webkit-reviews] review requested: [Bug 40278] [EFL] EFLWebKit doesn't support viewport meta tag : [Attachment 60686] viewport-patch-for-eflwebkit-15
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jul 6 23:05:38 PDT 2010
Gyuyoung Kim <gyuyoung.kim at samsung.com> has asked for review:
Bug 40278: [EFL] EFLWebKit doesn't support viewport meta tag
https://bugs.webkit.org/show_bug.cgi?id=40278
Attachment 60686: viewport-patch-for-eflwebkit-15
https://bugs.webkit.org/attachment.cgi?id=60686&action=review
------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
Sorry for my frequent patch uploading. It seems to me that ewk_private.h has
style errors as below,
WebKit/efl/ewk/ewk_private.h:51: Extra space between void and ewk_view_ready
[whitespace/declaration] [3]
WebKit/efl/ewk/ewk_private.h:52: Extra space between void and
ewk_view_title_set [whitespace/declaration] [3]
WebKit/efl/ewk/ewk_private.h:53: Extra space between void and
ewk_view_uri_changed [whitespace/declaration] [3]
WebKit/efl/ewk/ewk_private.h:54: Extra space between void and
ewk_view_load_started [whitespace/declaration] [3]
I think this style errors in ewk_private.h should be fixed as well.
More information about the webkit-reviews
mailing list