[webkit-reviews] review granted: [Bug 41691] Web Inspector: provide line numbers for inline styles. : [Attachment 60631] [PATCH] Proposed change.

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 41691: Web Inspector: provide line numbers for inline styles.
https://bugs.webkit.org/show_bug.cgi?id=41691

Attachment 60631: [PATCH] Proposed change.
https://bugs.webkit.org/attachment.cgi?id=60631&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
> +++ b/WebCore/html/HTMLStyleElement.cpp
> @@ -37,7 +38,10 @@ inline HTMLStyleElement::HTMLStyleElement(const
QualifiedName& tagName, Document
>      : HTMLElement(tagName, document)
>      , m_loading(false)
>      , m_createdByParser(createdByParser)
> +    , m_startLine(0)
>  {
> +    if (createdByParser && document && document->scriptableDocumentParser())

> +	   m_startLine = document->scriptableDocumentParser()->lineNumber();
>      ASSERT(hasTagName(styleTag));
>  }

One last thing, move this after the ASSERT.
An extra int per style element should be fine.
r=me