[webkit-reviews] review requested: [Bug 40278] [EFL] EFLWebKit doesn't support viewport meta tag : [Attachment 60684] viewport-patch-for-eflwebkit-14

[bugzilla-daemon at webkit.org]

Gyuyoung Kim <gyuyoung.kim at samsung.com> has asked  for review:
Bug 40278: [EFL] EFLWebKit doesn't support viewport meta tag
https://bugs.webkit.org/show_bug.cgi?id=40278

Attachment 60684: viewport-patch-for-eflwebkit-14
https://bugs.webkit.org/attachment.cgi?id=60684&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
Hello Kenneth,

As mentioned in Gustavo's comment above, EFL port doesn't have scale zoom type
yet. I heard that Gustavo will contribute scale zoom patch based on cairo. So,
in my opinion, I will modify this patch when the scale zoom patch is
contributed to WebKitEFL.

In ewk_view.cpp, I add a comment for this issue.

313 +	 // Since there's no scale separated from zooming in webkit-efl, this
functionality of
314 +	 // viewport meta tag is implemented using zoom. When scale zoom is
supported by webkit-efl,
315 +	 // this functionality will be modified by the scale zoom patch.
316 +	 priv->settings.zoom_range.min_scale = ZOOM_MIN;
317 +	 priv->settings.zoom_range.max_scale = ZOOM_MAX;


For now, in my opinion, this patch need to be landed first.