[webkit-reviews] review granted: [Bug 41726] Expose URL matching from WebUserContentURLPattern : [Attachment 60667] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jul 6 22:22:46 PDT 2010
Simon Fraser (smfr) <simon.fraser at apple.com> has granted Steve Falkenburg
<sfalken at apple.com>'s request for review:
Bug 41726: Expose URL matching from WebUserContentURLPattern
https://bugs.webkit.org/show_bug.cgi?id=41726
Attachment 60667: Patch
https://bugs.webkit.org/attachment.cgi?id=60667&action=review
------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
> Index: WebCore/ChangeLog
> ===================================================================
> + Expose URL matching from WebUserContentURLPattern
> + https://bugs.webkit.org/show_bug.cgi?id=41726
> +
> + No new tests. (OOPS!)
You should remove this line.
> Index: WebKit/mac/ChangeLog
> ===================================================================
> --- WebKit/mac/ChangeLog (revision 62607)
> +++ WebKit/mac/ChangeLog (working copy)
> @@ -1,3 +1,14 @@
> +2010-07-06 Steve Falkenburg <sfalken at apple.com>
> +
> + Reviewed by NOBODY (OOPS!).
> +
> + Expose URL matching from WebUserContentURLPattern
> + https://bugs.webkit.org/show_bug.cgi?id=41726
> +
> + * Misc/WebUserContentURLPattern.h:
> + * Misc/WebUserContentURLPattern.mm:
> + (-[WebUserContentURLPattern matchesURL:]):
I would like to see a few words about the change.
> Index: WebKit/win/ChangeLog
> ===================================================================
> + Expose URL matching from WebUserContentURLPattern
> + https://bugs.webkit.org/show_bug.cgi?id=41726
> +
> + * Interfaces/IWebUserContentURLPattern.idl:
> + * Interfaces/IWebView.idl:
> + * WebUserContentURLPattern.cpp:
> + (WebUserContentURLPattern::matchesURL):
> + * WebUserContentURLPattern.h:
You could explain the whitespace change to the idl file here at least.
r=me
More information about the webkit-reviews
mailing list